Use IcatSynonymAnalyzer to write Documents #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When indexing, we were using a non-synonym version of the analyzer, but when searching synonyms were being injected. When doing basic OR logic queries (e.g.
path to mr file) this is OK. The search term getsmolecular replacinjected, which isn't present in the Document but this is OK as it's an OR query.When doing an phrase query (the most common use case for this is to quote an exact filepath, which will remove the
/characters easily) each word has to match in order. At this point, there is no longer a match for the injected terms.By using
IcatSynonymAnalyzerfor both, we can ensure that the injected term appear in both the search query and in the indexed Document we match against.