Skip to content

639/foods page#647

Merged
EightBitByte merged 27 commits intodevfrom
639/foods-page
Apr 12, 2026
Merged

639/foods page#647
EightBitByte merged 27 commits intodevfrom
639/foods-page

Conversation

@jkhlin
Copy link
Copy Markdown
Member

@jkhlin jkhlin commented Feb 25, 2026

Summary

Implemented the My Foods page allowing users to see all of their rated and favorited foods

Changes

  • New components such as my foods card and upcoming event card
  • Added search and filtering functionality on my foods page with location picking, meal searching, and options to sort the foods on date modification, ratings, and alphabetically on the my foods page
  • Modified tRPC functions regarding stationName returning an empty string "" when dish.station.name doesn't exist

Testing Instructions

Sign on with Google authentication
Add some meals to the my foods page by rating or favoriting
Use the modification options to see the results of how the foods change on the page

Closes #639

@jkhlin jkhlin temporarily deployed to staging-647 February 25, 2026 05:24 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 February 25, 2026 05:24 Inactive
@EightBitByte EightBitByte self-requested a review February 26, 2026 01:11
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, great work! It's super close. Just a few nitpicks:

  1. The subtext under the "My Foods" title shouldn't show on mobile.
  2. On mobile, there is too much padding between meal cards.
  3. On screens in between large desktop and mobile, the filter menu gets cut off on the right.
Image

Also, please be more specific in the PR description.

@wilyan09007 wilyan09007 temporarily deployed to staging-647 February 27, 2026 04:40 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 February 27, 2026 04:40 Inactive
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. Looks great! Real quick before we merge, could you remove the excess padding at the top of the page when on mobile?

@jkhlin jkhlin temporarily deployed to staging-647 March 13, 2026 03:05 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 March 13, 2026 03:06 Inactive
@jkhlin jkhlin temporarily deployed to staging-647 March 13, 2026 03:32 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 March 13, 2026 03:32 Inactive
@LexTruong LexTruong self-requested a review March 31, 2026 23:53
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Padding is much better.

Image On mobile, could you make the padding consistent around the "Popular Today" and "Upcoming Events" titles? Also, the tags on the event cards get cutoff.

Copy link
Copy Markdown
Collaborator

@EightBitByte EightBitByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys! This PR still needs work.

Some things to note:

  1. Remember to have more detailed PR descriptions.
  2. It seems that you haven't completed the previous changes requested of you regarding the padding in the second image.

Please complete by this Tuesday (4/7)!

@jkhlin jkhlin temporarily deployed to staging-647 April 6, 2026 07:45 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 April 6, 2026 07:45 Inactive
Copy link
Copy Markdown
Collaborator

@EightBitByte EightBitByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Still needs tweaks, the tags get cutoff on mobile

@jkhlin jkhlin temporarily deployed to staging-647 April 10, 2026 02:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 April 10, 2026 02:16 Inactive
@jkhlin jkhlin temporarily deployed to staging-647 April 10, 2026 02:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-647 April 10, 2026 02:36 Inactive
Copy link
Copy Markdown
Collaborator

@EightBitByte EightBitByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@EightBitByte EightBitByte dismissed LexTruong’s stale review April 12, 2026 23:47

Completed review.

@EightBitByte EightBitByte merged commit 819b58b into dev Apr 12, 2026
1 of 2 checks passed
@EightBitByte EightBitByte deleted the 639/foods-page branch April 12, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants