Skip to content

640/dietary preferences and allergens#651

Open
Pranav-Batra wants to merge 11 commits intodevfrom
640/dietary-preferences-and-allergens
Open

640/dietary preferences and allergens#651
Pranav-Batra wants to merge 11 commits intodevfrom
640/dietary-preferences-and-allergens

Conversation

@Pranav-Batra
Copy link
Copy Markdown
Contributor

Summary

Users can see their dietary prefs/allergens in menu, see which meals conflict with their prefs, and view only meals that agree with their prefs

Changes

Removed hardcoded prefs/allergens on user menu with their actual prefs/allergens
Added red warning badge on meals that do not meet user preferences(either contain an allergen or dont meet dietary prefs)
Added "show preferences only" button to toggle the restaurant pages to only show meals that match user dietary preferences

Closes #640

Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! UI/UX is still finalizing the look of the conflict indicators, so we're not too worried about the styling. But what you have so far looks pretty nice.

  • Please add an indicator on the meal dialog/drawers for incompatibility.
  • Remove unnecessary comments.

Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Pranav, great work! Just a few touchups are needed now that the Figma has been finalized.

  • Match the styling for the badges on meal dialog/drawers. Note that they show what specific preference/allergen is problematic in that dish. Use MUI icons for the exclamation point icon.
  • I like the slightly greyed-out look on incompatible meal cards! Please change the "Conflict" badge on them to an icon though.
  • Make sure that warning icon also shows on meal cards for mobile screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants