Repository navigation
fix(composer): drop PHP 5.x; test on PHP 8.3 and 8.4 - #591
Merged
Merged
Conversation
PHP 8.1 is end of life and 8.2 ends 31 Dec 2026. Add a PHP 8.3 stack on Magento 2.4.8-p4 with OpenSearch, run CI on 8.3 and 8.4, and default local builds to 8.4. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Replace ~5.5.0|~5.6.0|>=7.0|>=8.0 with ^7.0||^8.0 so Composer no longer advertises PHP 5 support or unknown future majors. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Without --build, switching PHP versions reused the previously built magento-web image, so PHP=83 make up after PHP=84 still ran PHP 8.4. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Both jobs were named ci, so the PR showed only one of the two checks. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
cblanc
approved these changes
Oct 8, 2026
Member
|
🎉 This PR is included in version 2.7.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHP 8.1 is end of life and 8.2 ends on 31 Dec 2026. This PR moves Docker and CI onto 8.3 and 8.4, and narrows the PHP versions
composer.jsonadvertises.composer.json:"php": "~5.5.0|~5.6.0|>=7.0|>=8.0"becomes"^7.0||^8.0". This drops PHP 5.x and adds an upper bound, while 7.x and 8.x stores can still install.ci-81.ymlandci-82.yml, and addsci-83.ymlandci-84.yml. There was no CI job for 8.4 before.docker/83.ymlanddocker/83-arm64.ymlfor Magento 2.4.8-p4 on PHP 8.3 with OpenSearch. This is the same stack as 8.4.Makefile:PHP ?= 84, andSEARCH_HOSTuses OpenSearch for both 83 and 84.Dockerfile:BASE_IMAGEnow defaults to the 8.4 image.make upnow passes--build. Without it, switchingPHP=reused the previously builtmagento-webimage, so the container stayed on the old PHP version.README.mdandCLAUDE.mdnow give the PHP versions we test on, and the dead Magento 2.1–2.4 badges are replaced.The 8.1 and 8.2 Docker configs are still there, so those versions can be run locally.
Dependency:
ci-83usesidealpostcodes/magento-test:m2.4.8-p4-php8.3, which isn't on Docker Hub yet. That image is added in ideal-postcodes/magento-test (companion PR) and must be published withmake publish-83before this check can pass.Test plan
PHP=84 make up, then the Cypress e2e suite withak_go: 3/3 passed. The first run hit one flaky Autocomplete timeout, and the rerun passed.PHP=83 make upusing the locally built 8.3 image.php -vreports 8.3.35, and e2e passed 3/3.Link to Devin session: https://app.devin.ai/sessions/3421eaf791ce49b6bc6d2f214dcf8df2
Open in Devin Desktop: https://app.devin.ai/desktop/session/3421eaf791ce49b6bc6d2f214dcf8df2?variant=devin
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.