SPARK-2355: Migrate to Smack v4.5 #925
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MessageFilter intended to change text body of messages
Open
…g body, Date date)
stokito
force-pushed
the
SPARK-2355_migrate_smack_v4_5
branch
from
1fdffe7 to
d53176a
Compare
Contributor
Author
|
@Fishbowler please review the PR. So far, the only issue that I found is that you can send files but receiving of a file stuck in cycle. I'll debug and fix this later. |
…erties to set version
When a chat room is destroyed, the user in the room gets to see a message explaining what happened. Spark should not assume that the server will provide this message. Show a default message in case the server doesn’t sent one.
This is a very quick and dirty approach to rendering images. This change bypasses imporant security checks. Additional functionality is likely desired (such as: don't display images immediately, but show a button, which could prevent harm when abuse images are being received).
The FRAME_IMAGE is an app icon and it can be overridden via skin. It's ok that it's not found
…ecause it may be modified
…er.parse(): pass null for IqData
Now the minimal supported version is 11
stokito
force-pushed
the
SPARK-2355_migrate_smack_v4_5
branch
from
8e63594 to
949e6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Spark version now requires Java 11, so in the last commits I tried to upgrade it.