Skip to content

refactor: Optimize B2FloatW and B2Vec2W operations with 'in' modifier #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikpil merged 1 commit into from
Dec 27, 2025
Merged

refactor: Optimize B2FloatW and B2Vec2W operations with 'in' modifier #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/Box2D.NET/B2ContactSolvers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,37 +648,37 @@ public static B2FloatW b2SplatW(float scalar)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2AddW(B2FloatW a, B2FloatW b)
public static B2FloatW b2AddW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(a.X + b.X, a.Y + b.Y, a.Z + b.Z, a.W + b.W);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2SubW(B2FloatW a, B2FloatW b)
public static B2FloatW b2SubW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(a.X - b.X, a.Y - b.Y, a.Z - b.Z, a.W - b.W);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2MulW(B2FloatW a, B2FloatW b)
public static B2FloatW b2MulW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(a.X * b.X, a.Y * b.Y, a.Z * b.Z, a.W * b.W);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2MulAddW(B2FloatW a, B2FloatW b, B2FloatW c)
public static B2FloatW b2MulAddW(in B2FloatW a, in B2FloatW b, in B2FloatW c)
{
return new B2FloatW(a.X + b.X * c.X, a.Y + b.Y * c.Y, a.Z + b.Z * c.Z, a.W + b.W * c.W);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2MulSubW(B2FloatW a, B2FloatW b, B2FloatW c)
public static B2FloatW b2MulSubW(in B2FloatW a, in B2FloatW b, in B2FloatW c)
{
return new B2FloatW(a.X - b.X * c.X, a.Y - b.Y * c.Y, a.Z - b.Z * c.Z, a.W - b.W * c.W);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2MinW(B2FloatW a, B2FloatW b)
public static B2FloatW b2MinW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(
a.X <= b.X ? a.X : b.X,
Expand All @@ -689,7 +689,7 @@ public static B2FloatW b2MinW(B2FloatW a, B2FloatW b)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2MaxW(B2FloatW a, B2FloatW b)
public static B2FloatW b2MaxW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(
a.X >= b.X ? a.X : b.X,
Expand All @@ -700,7 +700,7 @@ public static B2FloatW b2MaxW(B2FloatW a, B2FloatW b)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2SymClampW(B2FloatW a, B2FloatW b)
public static B2FloatW b2SymClampW(in B2FloatW a, in B2FloatW b)
{
// a = clamp(a, -b, b)
return new B2FloatW(
Expand All @@ -712,7 +712,7 @@ public static B2FloatW b2SymClampW(B2FloatW a, B2FloatW b)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2OrW(B2FloatW a, B2FloatW b)
public static B2FloatW b2OrW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(
a.X != 0.0f || b.X != 0.0f ? 1.0f : 0.0f,
Expand All @@ -723,7 +723,7 @@ public static B2FloatW b2OrW(B2FloatW a, B2FloatW b)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2GreaterThanW(B2FloatW a, B2FloatW b)
public static B2FloatW b2GreaterThanW(in B2FloatW a, in B2FloatW b)
{
return new B2FloatW(
a.X > b.X ? 1.0f : 0.0f,
Expand All @@ -734,7 +734,7 @@ public static B2FloatW b2GreaterThanW(B2FloatW a, B2FloatW b)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2EqualsW(B2FloatW a, B2FloatW b)
public static B2FloatW b2EqualsW(in B2FloatW a, in B2FloatW b)
{
// TODO: @ikpil check float equal
return new B2FloatW(
Expand All @@ -746,13 +746,13 @@ public static B2FloatW b2EqualsW(B2FloatW a, B2FloatW b)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool b2AllZeroW(B2FloatW a)
public static bool b2AllZeroW(in B2FloatW a)
{
return a.X == 0.0f && a.Y == 0.0f && a.Z == 0.0f && a.W == 0.0f;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2BlendW(B2FloatW a, B2FloatW b, B2FloatW mask)
public static B2FloatW b2BlendW(in B2FloatW a, in B2FloatW b, in B2FloatW mask)
{
// component-wise returns mask ? b : a
return new B2FloatW()
Expand All @@ -765,19 +765,19 @@ public static B2FloatW b2BlendW(B2FloatW a, B2FloatW b, B2FloatW mask)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2DotW(B2Vec2W a, B2Vec2W b)
public static B2FloatW b2DotW(in B2Vec2W a, in B2Vec2W b)
{
return b2AddW(b2MulW(a.X, b.X), b2MulW(a.Y, b.Y));
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2FloatW b2CrossW(B2Vec2W a, B2Vec2W b)
public static B2FloatW b2CrossW(in B2Vec2W a, in B2Vec2W b)
{
return b2SubW(b2MulW(a.X, b.Y), b2MulW(a.Y, b.X));
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static B2Vec2W b2RotateVectorW(B2RotW q, B2Vec2W v)
public static B2Vec2W b2RotateVectorW(in B2RotW q, in B2Vec2W v)
{
return new B2Vec2W(b2SubW(b2MulW(q.C, v.X), b2MulW(q.S, v.Y)), b2AddW(b2MulW(q.S, v.X), b2MulW(q.C, v.Y)));
}
Expand Down
2 changes: 1 addition & 1 deletion src/Box2D.NET/B2Vec2W.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public struct B2Vec2W
public B2FloatW X;
public B2FloatW Y;

public B2Vec2W(B2FloatW X, B2FloatW Y)
public B2Vec2W(in B2FloatW X, in B2FloatW Y)
{
this.X = X;
this.Y = Y;
Expand Down
Loading