Pr/refactor b2 time of impact and b2 make separation function to use 'in' modifier #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifier - Updated `b2TimeOfImpact` to accept `B2TOIInput` by reference using the `in` keyword instead of `ref`. - Updated `b2MakeSeparationFunction` to accept `B2ShapeProxy` parameters by reference using the `in` keyword. - Adjusted call sites in `B2Solvers.cs`, `TimeOfImpact.cs`, and `B2DistanceTest.cs` to match the signature changes. - These changes improve API consistency and avoid unnecessary copying of large structs.
- Updated `b2MakeSeparationFunction` to accept `B2Sweep` parameters using the `in` keyword instead of `ref`. - Updated `b2TimeOfImpact` to use `ref readonly` for `B2Sweep` local variables to avoid copying. - This change reduces struct copying overhead for `B2Sweep` in TOI calculations.
ikpil
deleted the
pr/refactor--b2TimeOfImpact-and-b2MakeSeparationFunction-to-use-'in'-modifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.