Conversation
…gone phpGH-23650 made SQLite3::close() throw while a callback is running by counting re-entry into the four callback kinds, but each wrapper dropped the counter as soon as the userland call returned, before converting the return value and releasing it and the arguments. A destructor firing during that release still runs with sqlite3 on the stack, so it could close the database and finalize the statement being stepped, which is the crash phpGH-23650 was meant to stop. Drop the counter after the values are released instead.
Owner
Author
|
Submitted upstream as php#23734. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpGH-23650 made SQLite3::close() throw while a callback is running, but each callback wrapper dropped its re-entry counter as soon as the userland call returned, before the return value and arguments were converted and released. A destructor firing during that release still runs with sqlite3 on the stack, so it could close the database and finalize the statement being stepped, reaching the crash phpGH-23650 was meant to stop. Found while auditing the sibling in php#23728.