Repository navigation
1.0.4: no app picker or git window on Windows - #19
Merged
Merged
Conversation
session-start tested `[ -x bin/muninn ]`, which Git Bash also answers for muninn.exe, so it took the Unix branch and its `ln -s` copied the binary to ~/.local/bin/muninn with no extension. PowerShell finds that file first on PATH and asks Windows which app opens it. The script now looks for muninn.exe first and turns a copy left by the old check into muninn.exe, or removes it when one is already there. The install smoke test checks the names exactly. The background maintain started with DETACHED_PROCESS, so every git it ran opened its own console window. It now starts with CREATE_NO_WINDOW. Claude-Session: https://claude.ai/code/session_01Nb2ALSEZmiaV3CZhmidzij
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Windows problems, both seen on a machine running the 1.0.3 plugin.
"Select an app to open 'muninn'".
session-starttested[ -x bin/muninn ]. Git Bash answers that test formuninn.exetoo. So the script took the Unix branch, and itsln -swrote~/.local/bin/muninnas a copy with no extension. PowerShell finds that file first on PATH and hands it to Windows as a document, which opens the app picker.The script now looks for
muninn.exefirst. A copy left by the old check becomesmuninn.exewith the plugin mark, or is removed when amuninn.exeis already there.ci-install-smoke.shnow checks the names exactly and fails on an extensionlessmuninn.I ran the fixed script against a scratch
MUNINN_BIN_DIRin four starting states:muninn.exe,muninn.pluginmuninnonlymuninn.exe,muninn.pluginmuninnandmuninn.exemuninn.exemuninn.exemuninn.exe, untouchedOn the affected machine
Get-Command muninn -Allnow lists only.exepaths.A
git.execonsole window. The backgroundmaintainstarted withDETACHED_PROCESS. With no console of its own, everygitit ran got a visible one. It now starts withCREATE_NO_WINDOW | CREATE_NEW_PROCESS_GROUP.Version 1.0.4, with a CHANGELOG entry.
Locally on Windows the fmt check, clippy with
-D warnings, the workspace tests andscripts/ci-install-smoke.shpass.perf --strictdid not run here because it looks fortarget/release/muninnwithout.exe. The fault test was not run.