release: allow same-version npm publish so 26.5 ships#781
Merged
Conversation
publish-npm and publish-pi both run `npm version <semver>` against package.json files that are already bumped to the release version. npm aborts with "Version not changed" before publishing, so v26.5 reached GitHub + crates but never npm (registry still on 0.12.0). Add --allow-same-version to make the step a no-op when already aligned.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v26.5 release reached GitHub and crates.io, but npm + pi never published (npm registry is still on 0.12.0). Both
publish-npmandpublish-pifailed at the same step:npm/package.jsonandpi/package.jsonare already at26.5.0in the repo, sonpm version 26.5.0aborts before the publish step runs.Fix
Add
--allow-same-versionto bothnpm versionsteps so they no-op when the package is already at the target version instead of failing.Test plan
Context
Separate from the gitleaks/secret-scan question (that moves to a local pre-push hook; release CI keeps it dropped per ILO-502).