Skip to content

Conversation

@fintelia
Copy link
Contributor

The resize method is confusing because the dimensions of the output image won't necessarily match requested dimensions. This is in contrast to imageops::resize which returns an image of precisely the requested size. Deprecating the resize method and replacing it with an alternative makes the distinction clearer, though I'm open to alternative naming ideas.

I'll also say that if we didn't already have two methods to preserve aspect ratio while resizing an image, I probably won't support adding them. Given an exact resize method, building these other operations is a bit tricky but not something that necessarily needs to be in this crate. However since folks are already using them, the churn/disruption probably isn't worth it.

This PR also reorders some methods on DynamicImage so that the resize methods appear together in the docs.

This was referenced Nov 13, 2025
@Shnatsel
Copy link
Member

I went ahead and resolved the conflicts I caused by merging #2639

I've outright deleted resize because the signature changed and people would have to edit the code anyway.

This should be good to go after a cargo fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants