Fix kubectl-readonly Dockerfile to respect TARGETARCH - #212
Merged
Conversation
Hardcoded linux/amd64 downloaded an amd64 kubectl binary regardless of build host. On arm64 (e.g. Apple Silicon minikube), the binary can't exec -- ENOEXEC triggers the shell fallback that tries to interpret the raw ELF bytes as a script, surfacing as "Syntax error: \")\" unexpected" at tool-run time. Mirrors the same TARGETARCH pattern already used in tools/github/Dockerfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/kubectl-readonly/Dockerfilehardcodedlinux/amd64when downloading the pinned kubectl binary, regardless of the actual build host architecture.exec()— the kernel returnsENOEXEC, and the libc/shell fallback re-runs the raw ELF bytes as a shell script, surfacing at tool-run time as/usr/local/bin/kubectl: 1: Syntax error: ")" unexpected.ARG TARGETARCH(set automatically by BuildKit) through to kubectl's release asset path, mirroring the pattern already used intools/github/Dockerfile. Checksum verification is unchanged sincekubectl.sha256has no filename in it.Test plan
docker build -f tools/kubectl-readonly/Dockerfile -t kubectl-readonly:latest .succeeds on this arm64 hostdocker run --rm --entrypoint /usr/local/bin/kubectl kubectl-readonly:latest version --clientnow runs cleanly instead of failing with the syntax error🤖 Generated with Claude Code
https://claude.ai/code/session_01DuP65eSctHC9RYHkMBzJoU