feat(mobile): add to album from asset viewer #23608
Open
+260
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwees
changed the title
bwees
requested changes
Nov 7, 2025
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Outdated
Show resolved
Hide resolved
Comment on lines
+190
to
+200
| String? _remoteIdOf(Object asset) { | ||
| if (asset is RemoteAsset) return asset.id; | ||
|
|
||
| try { | ||
| final dyn = asset as dynamic; | ||
| final rid = dyn.remoteId ?? dyn.id; | ||
| return rid is String ? rid : null; | ||
| } catch (_) { | ||
| return null; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Lets remove this function and just add a check for if (asset is RemoteAsset) instead of calling this function. Additionally, we should never fall back to the id of an asset as that is not related to remoteId in any way.
Member
There was a problem hiding this comment.
The only weird case would be viewing an asset that has been uploaded to the server but is being viewed from the local library timeline. Using hasRemote instead of checking if the asset is a RemoteAsset type has burned us in the past so I always use th "is" check :).
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Show resolved
Hide resolved
| return; | ||
| } | ||
|
|
||
| final addedCount = await ref.read(remoteAlbumProvider.notifier).addAssets(album.id, [id]); |
Member
There was a problem hiding this comment.
Suggested change
| final addedCount = await ref.read(remoteAlbumProvider.notifier).addAssets(album.id, [id]); | |
| final addedCount = await ref.read(remoteAlbumProvider.notifier).addAssets(album.id, [asset.remoteId]); |
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Show resolved
Hide resolved
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Show resolved
Hide resolved
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Show resolved
Hide resolved
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Show resolved
Hide resolved
mobile/lib/presentation/widgets/action_buttons/add_action_button.widget.dart
Show resolved
Hide resolved
…archiving, and moving to locked folders
…on.widget.dart Co-authored-by: Brandon Wees <[email protected]>
….dart Co-authored-by: Brandon Wees <[email protected]>
bwees
force-pushed
the
feature/add_to_album_from_photo_view
branch
from
20cbe81 to
2a001ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature Request: #23266
Added an "add" button at the bottom of the photo-viewer, with a toast menu: "Album", "Archive", "Locked Folder"
This changes enables a user to add photos directly to an album while browsing through them in the photo viewer.
Selecting Add->Album will open the AlbumSelector widget.
Fixes # (issue)
none
How Has This Been Tested?
Manual testing following scenarios:
General scenarios:
Each above scenario:
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
no LLM
...