Skip to content

Conversation

@meesfrensel
Copy link
Contributor

Description

When editing a shared link with an expiry date of e.g. 'in 7 days', the 'Expire after' dropdown is disabled and shows 'never', instead of 'in 7 days'. The ux for changing that date, or not, is not so intuitive with the switch to enable changing the date. I added the current expiry date, if it's not 'never', to the option list and set it as selected. That way, it's clear to the user nothing would be changed per se, but it's also easy to change it when you want to do so.

If you agree with these changes I'll try to port them to mobile as well.

Not 100% happy about the solution for overwriting the expiryOption state; I got a svelte warning about that, but not sure how to best handle.

Fixes #22147

How Has This Been Tested?

  • Create a new shared link; nothing unusual happens. Normal select options. Select a not-never expiry date.
  • Go to shared links and see 'Expires in 29 minutes' at the shared link info card.
  • Edit the shared link. The selected default is 'in 29 minutes (unchanged)', and all other options are there, as well.
  • Verify all combinations of changing 'unchanged', 'never', 'in x minutes' to something else works as expected.

Screenshots (if appropriate)

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

None

@immich-push-o-matic
Copy link

immich-push-o-matic bot commented Nov 6, 2025

Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web. A maintainer will add the required label.

@danieldietzler
Copy link
Member

Superseded by #23803, sorry!

@meesfrensel meesfrensel deleted the fix/shared-link-expiration branch November 12, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edited shared link shows expiration time: never

2 participants