Update transcoding without tonemapping (VAAPI) #23680
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in issue #23631:
out_range=pc. Looks like ffmpeg is able to figure it out automatically and doing it betterscale_vaapi=format=...(fix(transcode): conditionally fix VAAPI filter order for HEVC on Haswell #18111)scale_vaapiif scaling is not required. There might be a possibility that samescale_vaapi=format=...is needed on some hardware but I can't verify it. On my hardware it works without itFixes #23631
How Has This Been Tested?
Tested several transcoding options with several videos
AMD Ryzen 5 5600G
HW tonemapping doesn't work on this machine so I can't test it
Intel(R) Core(TM) i5-8265U
Note: "wrong colors" issue also present with hw tonemapping in main branch so there is no regression
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
none