fix(server): properly handle HEAD requests to SSR paths #23788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the HTTP HEAD method not working for paths that are handled by ApiService.ssr.
The HEAD method is supposed to return the same metadata as a GET request but without the body (https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Methods/HEAD).
Previously this didn't happen because the
ApiService.ssrchecked if the method is GET and otherwise forwards the request to the api handlers which would result in a 404. NowApiService.ssralso checks if the method is HEAD and handles the request. The html is still passed to res.send so that express can determine the proper Content-Length.How Has This Been Tested?
I manually tested the status and headers (besides Date) being the same for GET and HEAD requests. I didn't write a unit test as
ApiService, unlike all the other services, doesn't have a spec file and isn't able to usenewTestServicebecause it doesn't extendBaseService.I also ran
pnpm testand it didn't show any regressions.Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
No AI used.