This repository was archived by the owner on Jun 19, 2026. It is now read-only.
cmake: Add missing -Wl,-znow flag to callgates .so - #624
Merged
Conversation
This triggered an issue with the three_keys_minimal test because the process needed to resolve a symbol for lib 2 and accessed data belonging to the main binary. This change ensures that symbols are resolved when lib 2 is dlopen'ed at the beginning as intended
ayrtonm
force-pushed
the
am/missing_flag
branch
from
August 11, 2025 23:04
3c0622d to
4b0663d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This triggered sporadic issues with the three_keys_minimal test because the process needed to resolve a symbol for lib 2 while compartment permissions were enabled and sometimes accessed data belonging to the main binary. This change ensures that symbols are resolved when lib 2 is dlopen'ed at the beginning as intended. Originally part of PR #589.