transpile: Deduplicate in/decrement operator handling - #1921
Merged
Conversation
Rua
force-pushed
the
indecrement-operator-refactor
branch
from
July 24, 2026 15:09
b14efc8 to
11dbc42
Compare
ahomescu
requested changes
Jul 25, 2026
| bar = (bar as ::core::ffi::c_int + 1) as Bar; | ||
| let c2rust_fresh0 = foo; | ||
| foo = foo.wrapping_add(1); | ||
| foo = (foo as ::core::ffi::c_uint).wrapping_add(1) as Foo; |
Contributor
There was a problem hiding this comment.
Where did these extra casts come from?
Contributor
Author
There was a problem hiding this comment.
They are produced the same way as they are for regular compound assignment foo += 1. Specifically, the compute_lhs_type_id and compute_res_type_id, which specify when a compound assignment has its arithmetic/logic operator performed using a different type from its LHS operand.
In this case, the casts are superfluous, but that is because convert_cast_from_enum and convert_cast_to_enum unconditionally cast. a589bee (as part of #1620) is meant to fix that.
ahomescu
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for post-increment basically reimplements part of the pre-increment code as well as parts of the compound assignment code. This PR deduplicates that by introducing a new common function, and also makes pre-increment emit a Rust compound assignment when it can, resulting in cleaner output.