transpile: Do not try to eliminate casts from integer literal to enum - #1965
Open
Rua wants to merge 4 commits into
Open
transpile: Do not try to eliminate casts from integer literal to enum #1965Rua wants to merge 4 commits into
Rua wants to merge 4 commits into
Conversation
Rua
force-pushed
the
literal-to-enum-cast
branch
from
August 1, 2026 13:12
5a17bbf to
c79ed0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c2rust has for a long time created a "shortcut" if an integer literal is cast to an enum type, first added in e9e7e46. Instead of translating each of them as-is, it would attempt to emit an enum constant and fall back to an integer literal otherwise. But I think that's bad:
So I think it's best to just remove it and emit the literal and cast as they are.