Skip to content

feat(wallet): pass chain correct chain to transaction confirmation app #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nattb8 merged 1 commit into from
Jan 21, 2026
Merged

feat(wallet): pass chain correct chain to transaction confirmation app #2773

nattb8 merged 1 commit into from
Jan 21, 2026

Conversation

@nattb8
Copy link
Contributor

@nattb8 nattb8 commented Jan 21, 2026 •
edited by atlassian bot
Loading

Hi👋, please ensure the PR title follows the below standards:

  • PR is titled with conventional commit style naming: type(scope): message. For example: feat(passport): my new feature
  • If you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities, add a ! after the type(scope), for example feat(passport)!: my new breaking feature

Summary

  • Update the wallet confirmation flow to pass the chain name to the confirmation app for both transaction and message confirmation requests.
  • Move chain related files into the network/ directory.

ID-4264

@nattb8 nattb8 requested a review from a team as a code owner January 21, 2026 02:20
@nx-cloud
Copy link

nx-cloud bot commented Jan 21, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 54b8817

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 3m 9s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m 28s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-21 02:47:43 UTC

@nattb8 nattb8 force-pushed the feat/confirmation branch 2 times, most recently from 2e1d482 to b66ddd2 Compare January 21, 2026 02:32
@nattb8 nattb8 force-pushed the feat/confirmation branch from b66ddd2 to 54b8817 Compare January 21, 2026 02:34
@nattb8 nattb8 added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 800c295 Jan 21, 2026
7 checks passed
@nattb8 nattb8 deleted the feat/confirmation branch January 21, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JCSanPedro JCSanPedro JCSanPedro approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nattb8 @JCSanPedro