Skip to content

feat: add loki-skills pre-install to all packs #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royosherove merged 1 commit into from
May 18, 2026
Merged

feat: add loki-skills pre-install to all packs #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packs/claude-code/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,12 @@ CLAUDE_VER="$(claude --version 2>/dev/null || echo unknown)"
ok "claude --version: ${CLAUDE_VER}"

# ── Done ─────────────────────────────────────────────────────────────────────

# ── Install loki-skills library ───────────────────────────────────────────────
# Best-effort: pre-install skills (shared or pack-specific).
PACK_SKILLS_DIR="${HOME}/.local/share/lowkey/skills"
ensure_skills_clone "${PACK_SKILLS_DIR}" || true
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Define ensure_skills_clone before using it

This commit adds ensure_skills_clone calls in six pack installers, but there is no ensure_skills_clone function or executable anywhere in the repo (including packs/common.sh, which these scripts source). At runtime this line emits command not found; because it is wrapped in || true, the install appears to continue while silently skipping the intended skills bootstrap, so the new feature does not work in any of the touched packs.

Useful? React with 👍 / 👎.

log "Skills installed to ${PACK_SKILLS_DIR}"
write_done_marker "claude-code"
printf "\n[PACK:claude-code] INSTALLED — claude CLI ready (model: %s via Bedrock region: %s)\n" \
"${MODEL}" "${REGION}"
6 changes: 6 additions & 0 deletions packs/codex-cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,5 +290,11 @@ cat << NOTICE
NOTICE

# ── Done ──────────────────────────────────────────────────────────────────────

# ── Install loki-skills library ───────────────────────────────────────────────
# Best-effort: pre-install skills (shared or pack-specific).
PACK_SKILLS_DIR="${HOME}/.local/share/lowkey/skills"
ensure_skills_clone "${PACK_SKILLS_DIR}" || true
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Implement ensure_skills_clone before invoking it

The new skills bootstrap path is currently a no-op because ensure_skills_clone is invoked but never defined anywhere in the repository (I checked packs/common.sh and repo-wide rg), so this line resolves to command not found at runtime. Because it is wrapped in || true, each installer silently continues and then logs a false success message (Skills installed...) even though no clone occurred. This breaks the feature introduced by this commit across all updated pack installers that use the same call pattern.

Useful? React with 👍 / 👎.

log "Skills installed to ${PACK_SKILLS_DIR}"
write_done_marker "codex-cli"
printf "\n[PACK:codex-cli] INSTALLED — codex CLI ready (model: %s)\n" "${MODEL}"
6 changes: 6 additions & 0 deletions packs/hermes/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,12 @@ else
fi

# ── Done ──────────────────────────────────────────────────────────────────────

# ── Install loki-skills library ───────────────────────────────────────────────
# Best-effort: pre-install skills (shared or pack-specific).
PACK_SKILLS_DIR="${HOME}/.local/share/lowkey/skills"
ensure_skills_clone "${PACK_SKILLS_DIR}" || true
log "Skills installed to ${PACK_SKILLS_DIR}"
write_done_marker "hermes"
printf "\n[PACK:hermes] INSTALLED — hermes CLI ready (model: %s via bedrockify:%s)\n" \
"${MODEL}" "${BEDROCKIFY_PORT}"
6 changes: 6 additions & 0 deletions packs/ironclaw/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,12 @@ systemctl --user enable ironclaw 2>/dev/null || true
ok "Systemd service installed with EnvironmentFile + --no-onboard"

# ── Done ─────────────────────────────────────────────────────────────────────

# ── Install loki-skills library ───────────────────────────────────────────────
# Best-effort: pre-install skills (shared or pack-specific).
PACK_SKILLS_DIR="${HOME}/.ironclaw/skills"
ensure_skills_clone "${PACK_SKILLS_DIR}" || true
log "Skills installed to ${PACK_SKILLS_DIR}"
write_done_marker "ironclaw"
printf "\n[PACK:ironclaw] INSTALLED — ironclaw CLI ready\n"
printf " model: %s via bedrockify:%s\n" "${MODEL}" "${BEDROCKIFY_PORT}"
Expand Down
6 changes: 6 additions & 0 deletions packs/kiro-cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,12 @@ if [[ -f "${SHELL_PROFILE}" && -d /etc/profile.d ]]; then
warn "Could not install shell profile (permission denied?)"
fi

# ── Install loki-skills library ───────────────────────────────────────────────
# Best-effort: pre-install skills to kiro workspace.
PACK_SKILLS_DIR="${HOME}/.kiro/skills"
ensure_skills_clone "${PACK_SKILLS_DIR}" || true
log "Skills installed to ${PACK_SKILLS_DIR}"

# ── Done ──────────────────────────────────────────────────────────────────────
write_done_marker "kiro-cli"
if [[ -n "${PACK_ARG_API_KEY}" ]]; then
Expand Down
8 changes: 8 additions & 0 deletions packs/pi/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,14 @@ EOF
chmod 600 "${HOME}/.pi/agent/models.json"
ok "Pi config written: ${HOME}/.pi/agent/models.json"

# ── Install loki-skills library ───────────────────────────────────────────────
# Best-effort: pre-install skills as reference docs for Pi users.
# Skills are stored per-agent (not auto-discovered), so users must manually
# create TypeScript extensions to use them. This ensures they're always available.
PACK_SKILLS_DIR="${HOME}/.pi/agent/skills"
ensure_skills_clone "${PACK_SKILLS_DIR}" || true
log "Skills installed to ${PACK_SKILLS_DIR} (reference docs; manual extension creation needed)"

# ── Sanity check ─────────────────────────────────────────────────────────────
step "Sanity check"

Expand Down