CROSSLINK-197 Patron Request API improvements #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanisSaldabols
force-pushed
the
CROSSLINK-197
branch
from
97d3364 to
233bf82
Compare
JanisSaldabols
force-pushed
the
CROSSLINK-197
branch
from
233bf82 to
49b290d
Compare
jakub-id
reviewed
Jan 23, 2026
| index.Links.EventsLink = toLink(r, EVENTS_PATH, "", "") | ||
| index.Links.LocatedSuppliersLink = toLink(r, LOCATED_SUPPLIERS_PATH, "", "") | ||
| index.Links.PeersLink = toLink(r, PEERS_PATH, "", "") | ||
| index.Links.PatronRequestLink = toLink(r, PATRON_REQUEST_PATH, "", "") |
|
|
||
| if dbparams.Offset > 0 { | ||
| pOffset := dbparams.Offset - dbparams.Limit | ||
| func CollectAboutData(fullCount int64, offset int32, limit int32, r *http.Request) oapi.About { |
Contributor
There was a problem hiding this comment.
@JanisSaldabols Can we move this to api/common.go?
| locatedSuppliersLink: | ||
| type: string | ||
| description: Link to located suppliers | ||
| patronRequestLink: |
Contributor
There was a problem hiding this comment.
should be patronRequestsLink
| get: | ||
| summary: Retrieve patron requests | ||
| tags: | ||
| - PR |
Contributor
There was a problem hiding this comment.
can we rename this tag to patron-request-api
| } | ||
|
|
||
| func NewApiHandler(prRepo pr_db.PrRepo, eventBus events.EventBus, tenant common.Tenant) PatronRequestApiHandler { | ||
| func NewApiHandler(prRepo pr_db.PrRepo, eventBus events.EventBus, tenant common.Tenant, limitDefault int32) PatronRequestApiHandler { |
Contributor
There was a problem hiding this comment.
rename to NewPrApiHandler
| } | ||
| } | ||
|
|
||
| func (a *PatronRequestApiHandler) getSymbolForRequest(r *http.Request, tenant *string, symbol *string) (string, error) { |
Contributor
There was a problem hiding this comment.
can this be moved to api/common.go and used across all APIs?
| writeJsonResponse(w, resp) | ||
| } | ||
|
|
||
| func addAccessRestrictions(cql *string, side string, symbol string) string { |
Contributor
There was a problem hiding this comment.
we need to verify if this can be subject to CQL injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.