Merged
Conversation
CIRC-2463 better hold-by-barcode response
CIRC-2439: Fix allowed service points for Restricted items
…ests and circulation/requests/{id} endpoints (folio-org#1623)
* Update Request.java
Update the GET methods for the circulation/requests and circulation/requests/{id} endpoints to handle anonymized records.
* move anon. from request to RequestRepresentation.java
* remove the null check isAnonymized
* add null check in extenedRepresentation
* add null check in isAnon.
* remove the space
* add test
* add more test and correct typo
* correction on test
* CIRC-2399 Test * CIRC-2399 Fix staff slips issues * CIRC-2399 Remove redundant fields from StaffSlipsContext * CIRC-2399 Remove redundant fields from StaffSlipsContext * CIRC-2399 Fix typos * CIRC-2399 Fix typos
* Purpose/Overview:
Create a /request-anonymization/{request UUID} Post API for anonymizing one a single closed request
Requirements/Scope:
Verify that the user has the UI-Requests Request-Anonymize Single Execute capability
Anonymizes request as described in https://folio-org.atlassian.net/browse/CIRC-2292
Returns an error message if anonymization fails
Acceptance Criteria:
Post API for single request anonymization by UUID is created
* clean the request-anonymization.raml
* add description to anonymize-single-request-response.json
* solve issues and increase test coverage
* solve issues and increase test coverage
* update RequestAnonymizationResource, RequestAnonymizationService, update wiring, update tests.
* tidy up the code and remove duplicates and unused codes
* remove the unused method parameter. edit permission.
* code corrections according to code review
* delete extra space
* cla: retry signature
* remove unused local variable.
* Refine request anonymization endpoint, permissions, and tests
- Add permissionsRequired and modulePermissions for /request-anonymization/{requestId} handler in ModuleDescriptor-template.json
- Use UuidUtil.isUuid in RequestAnonymizationService and return failed validation when requestId is invalid
- Simplify fetchRequest to delegate to requestRepository.getById without extra failWhen logic
- Change scrubPii to return Request instead of Result and call it via mapResult
- Simplify publishLog to return Result<Void> from eventPublisher without remapping
- Fix Result chain to use flatMapResult for validateStatus and after(...) for async update/log
- Remove unused validationError helper that relied on old ValidationError constructor
- Update RequestAnonymizationServiceTest to inject mocks via constructor (remove reflection)
- Adjust not-found test to return failed RecordNotFoundFailure instead of succeeded(null)
- Reorder imports in tests to follow mod-circulation import order convention
* CIRC-2364-Anonymize Single Request Post API
remove a unused line
* CIRC-2364-Anonymize Single Request Post API
Fix displayName/description wording: "anonymize request" instead of "anonymize requests".
Update permission name to modperms.circulation.requests.anonymize.single.
Remove redundant modulePermission already included in anonymize.single.
Inline RequestRepository.using(...) initializer into single line.
Condense ValidationErrorFailure.failedValidation(...) into one line.
Add UUID format validation to requestId in anonymize-single-request-response.json.
Remove extra spacing alignment in EventPublisher .put() calls.
Replace wildcard imports in RequestAnonymizationServiceTest with explicit imports.
Reorder imports to follow mod-circulation import convention.
Adjust permission naming to follow FOLIO scope convention (item vs collection).
* CIRC-2503 revert CIRC-2416 changes for pick slips * CIRC-2503 remove unused imports * CIRC-2503 remove redundant configuration
* CIRC-2343, remove the metadata. * chore: link BE settings ticket to capability sets (no code changes)
* CIRC-2443 Migrate to Vertx 5.0 and RMB 36.0 * CIRC-2443 Fix logging errors * CIRC-2443 Fix dependencies * CIRC-2443 Downgrade testcontainers * CIRC-2443 Migrate from Junit 4 to Junit 5 * CIRC-2443 Migrate from Junit 4 to Junit 5
* circ-2292-Request-Anonymization - Add RequestAnonymizationSettings domain model - Add RequestAnonymizationSettingsRepository to read circulation settings - Add RequestAnonymizationRecords container for bulk anonymization results - Add unit tests for settings, records, and repository - Fix settings parsing and remove incorrect IDE auto-import * circ-2292-Request-Anonymization improve test coverage. * circ-2292-Request-Anonymization improve maintainability, remove unused virables and remove commented out lines. * chore: retrigger CI * circ-2292-Request-Anonymization remove the unused import
* CIRC-2523 Initial implementation * CIRC-2523 Fix DefaultModuleIdProvider * CIRC-2523 Change timer * CIRC-2523 Run every 60s * CIRC-2523 Implementation and tests * CIRC-2523 Remove consumer group cleaner * CIRC-2523 Set "kafka.consumer.auto.offset.reset" --------- Co-authored-by: alexanderkurash <alexander.kurash@gmail.com>
…nt (folio-org#1647) * mod-circulation 2520 Register an internal POST endpoint Initialize tenant context and clients Provide a clear handoff point for future anonymization logic Avoid exposing the endpoint via RAML (internal use only) * mod-circulatoin-2520 format correction * Trigger CI rerun * mod-circulatoin-2520 removing the note * Trigger CI rerun * mod-circulatoin-2520 add test * mod-circulatoin-2520 remove the partially code and unneeded test, and leave handover point and note * Trigger CI rerun * mod-circulatoin-2520 fix issues
) * CIRC-2515 Migrate noticeLimit * CIRC-2515 Migrate `loan_history` and `PRINT_HOLD_REQUESTS` * CIRC-2515 Migrate `other_settings` * CIRC-2515 Migrate TLR settings * CIRC-2515 Extract CirculationSettingsService * CIRC-2515 Revert changes in POM * CIRC-2515 Fix tests * CIRC-2515 Move methods from `SettingsFixture` to `CirculationSettingsFixture` * CIRC-2515 Fix tests * CIRC-2515 Refactoring * CIRC-2515 Refactoring * CIRC-2515 Fix and refactor tests * CIRC-2515 More unit tests * CIRC-2515 Remove unused code * CIRC-2515 Remove configuration interface and permissions from `ModuleDescriptor-template.json` --------- Co-authored-by: Roman Barannyk <53909129+roman-barannyk@users.noreply.github.com>
https://folio-org.atlassian.net/browse/CIRC-2543 Purpose Test dependency com.github.tomakehurst:wiremock-jre8:2.35.0 has this vulnerability: * CVE-2023-41329 - GHSA-pmxq-pj47-j8j4 - Domain restrictions bypass via DNS Rebinding Approach Upgrade wiremock from 2.35.0 to 3.13.2
CIRC-2543: Upgrade wiremock from 2.35.0 to 3.13.2 fixing CVE-2023-41329
…-in (folio-org#1652) * CIRC-2535: Fix request losing retrieval service point name upon check-in * CIRC-2535 Add tests to ensure retrieval service point names are retained after check-in * CIRC-2535: Extract methods in ServicePointRepository * CIRC-2535 Refactor enrichRequestsWithServicePoints method to use MultipleRecords directly * CIRC-2535 Add tests to verify service point enrichment behavior when service points are not found * CIRC-2535 Update NEWS.md --------- Co-authored-by: oleksandr_vidinieiev <oleksandr_vidinieiev@epam.com>
…1654) * CIRC-1807 Improve logging, cleanup sensitive data in logs * CIRC-1807 incorporating review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
TODOS and Open Questions
Learning