feat: structured error handling and input validation for upload API#99
Open
Krushna-Pisal wants to merge 2 commits into
Open
feat: structured error handling and input validation for upload API#99Krushna-Pisal wants to merge 2 commits into
Krushna-Pisal wants to merge 2 commits into
Conversation
Adds structured task states, metadata tracking, and improved error handling for Celery upload tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces structured error responses and improves input validation in the upload API.
Problem
Currently, error responses in the upload endpoint are unstructured and inconsistent, making it difficult to handle errors reliably on the client side. Additionally, invalid inputs (such as malformed source URLs) can lead to unexpected failures during processing.
Solution
Introduced a reusable error handler utility (
helpers/error_handler.py) for consistent error responsesStandardized error response format with:
code(machine-readable)message(user-friendly)retryableflagdetailsUpdated key error cases in
/api/uploadto use the new structured formatAdded input validation for
srcUrlto prevent invalid requests before processingExample Response
{ "error": { "code": "INVALID_INPUT", "message": "Invalid source URL provided", "retryable": false } }Benefits
Scope
Changes are currently applied to the upload endpoint. The same structure can be extended to other APIs in future for consistency.
Notes