Skip to content

additional logging for errors #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

additional logging for errors #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/IndieAuth/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,28 +90,33 @@ public static function complete($params) {
$requiredSessionKeys = ['indieauth_entered_url', 'indieauth_state', 'indieauth_authorization_endpoint'];
foreach($requiredSessionKeys as $key) {
if(!isset($_SESSION[$key])) {
error_log("IndieAuth\Client: missing $key from session");
return self::_errorResponse('invalid_session',
'The session was missing data. Ensure that you are initializing the session before using this library');
}
}

if(isset($params['error'])) {
error_log("IndieAuth\Client: found error in params");
return self::_errorResponse($params['error'], isset($params['error_description']) ? $params['error_description'] : '');
}

if(!isset($params['code'])) {
error_log("IndieAuth\Client: missing code in params");
return self::_errorResponse('invalid_response',
'The response from the authorization server did not return an authorization code or error information');
}

$response = self::validateStateMatch($params, $_SESSION['indieauth_state']);
if ($response instanceof ErrorResponse) {
error_log("IndieAuth\Client: failed to validate that the state matched");
return $response->getArray();
}

if (isset($_SESSION['indieauth_issuer'])) {
$response = self::validateIssuerMatch($params, $_SESSION['indieauth_issuer']);
if ($response instanceof ErrorResponse) {
error_log("IndieAuth\Client: failed to validate that the issuer matched");
return $response->getArray();
}
}
Expand Down Expand Up @@ -227,16 +232,19 @@ private static function _isIssuerValid($issuer, $metadata_endpoint) {
$parts = parse_url($issuer);

if (!array_key_exists('scheme', $parts) || $parts['scheme'] != 'https') {
error_log("IndieAuth\Client.php: failed scheme");
return false;
}

if (array_key_exists('query', $parts) || array_key_exists('fragment', $parts)) {
error_log("IndieAuth\Client.php: failed query or fragment");
return false;
}

$metadata_endpoint = self::normalizeMeURL($metadata_endpoint);

if (strpos($metadata_endpoint, $issuer) !== 0) {
error_log("IndieAuth\Client.php: failed metadata and issuer comparison");
return false;
}

Expand Down