Skip to content

fix(ci): tolerate CRLF in uv.lock version check#35

Merged
infiniV merged 1 commit into
mainfrom
fix/version-check-crlf
Jun 11, 2026
Merged

fix(ci): tolerate CRLF in uv.lock version check#35
infiniV merged 1 commit into
mainfrom
fix/version-check-crlf

Conversation

@infiniV

@infiniV infiniV commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Problem

The v1.6.2 release workflow failed on build-windows at Verify version consistency:

ERROR: version pattern not found in uv.lock

The Linux job passed the identical check. Root cause: scripts/version.mjs matches the uv.lock virtual-root block with a literal \n:

re: /(name = "voiceflow"\nversion = ")([^"]+)(")/

The Windows CI runner checks out with core.autocrlf=true and there is no .gitattributes pinning uv.lock to LF, so the file lands with CRLF and \n never matches \r\n. This is the new version-drift guard added this cycle (didn't exist for the v1.6.1 release), so the regression only surfaced now.

Fix

Make the separator CRLF-tolerant: \n\r?\n. Verified the regex matches both LF and CRLF inputs, and the bump replacement preserves the captured separator so it stays correct on either platform.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@infiniV, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f127503a-5fcf-47eb-963e-be681c5b7238

📥 Commits

Reviewing files that changed from the base of the PR and between 19b4958 and 169d3ab.

📒 Files selected for processing (1)
  • scripts/version.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/version-check-crlf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@infiniV infiniV merged commit f63609a into main Jun 11, 2026
3 checks passed
@infiniV infiniV deleted the fix/version-check-crlf branch June 11, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant