Jmx support #134
Open
Jmx support #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanemerson
reviewed
Sep 3, 2024
| {{- if and (eq (.Values.deploy.expose.type) "NodePort") (.Values.deploy.expose.nodePort) }} | ||
| nodePort: {{ .Values.deploy.expose.nodePort }} | ||
| {{- end}} | ||
| - port: 9999 |
Contributor
There was a problem hiding this comment.
We should only expose this port if jmx is enabled and I don't think we want to expose it via a nodeport as the port value from the template .Values.deploy.expose.nodePort will already be used by the "infinispan" port defined above.
I think the code should be more like:
{{- if .Values.deploy.jmx.enabled }}
- port: 9999
protocol: TCP
name: jmx
{{- end}}
Collaborator
|
with and I can't connect with jconsole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add JMX support natively on helm charts