Allow Zone file to be created from a template #129
Conversation
| file.write "send\n" | ||
| file.close | ||
| #puts File.read(file.path) | ||
|
|
There was a problem hiding this comment.
Could you get rid of this please?
| mode => '0644', | ||
| replace => ($zone_file_mode == 'managed'), | ||
| content => $content, | ||
| audit => [ content ], |
There was a problem hiding this comment.
You'll need to get rid of the audit parameters on this and the other file resource. They've been removed on master, and that's the source of the merge conflict.
|
I've been hesitant to add direct control over zone file content to this module. Conventional zone file handling defeats the option to configure a dynamic zone, which is a necessary precondition for using some of the advanced features of the module. This seems appropriately limited in scope, though. Just a couple of minor clean ups and it will be ready to merge. |
|
Also, do you mind too much if I squash the branch in the merge? |
|
Yes, sure. It will be a couple of days until I get to your other comments. |
2 participants
Follow up from #101 to allow for putting in the file as content. If the $content parameter is non-empty use it as first preference.