Skip to content

Add stacked markdown review comments#489

Draft
lmist wants to merge 1 commit into
inkeep:mainfrom
lmist:feature/stacked-markdown-comments
Draft

Add stacked markdown review comments#489
lmist wants to merge 1 commit into
inkeep:mainfrom
lmist:feature/stacked-markdown-comments

Conversation

@lmist

@lmist lmist commented Jul 7, 2026

Copy link
Copy Markdown

What & why

Adds inline review comments for selected text in the WYSIWYG markdown editor. Users can select arbitrary passages, add multiple anchored comments, review them in the right-side Comments panel, and prepare the collected feedback for agent handoff.

Known issue: in manual testing, clicking Send currently appears to do nothing. This PR leaves that behavior as a follow-up and calls it out explicitly.

How this was verified

Targeted checks passed:

  • bun run test:dom src/editor/comments/CommentSelectionButton.dom.test.tsx src/components/DocPanel.dom.test.tsx src/components/DocumentCommentsPanel.dom.test.tsx
  • bun test --timeout 30000 --conditions development src/editor/comments/comment-store.test.ts
  • bun run typecheck --filter @inkeep/open-knowledge-app
  • targeted Biome/Oxlint checks
  • git diff --check

Manual UI screenshot:

Stacked markdown comments

This screenshot shows selected markdown text highlighted in the editor, stacked comments in the right-side Comments panel, comment editing, and code-block selection highlighting.

Checklist

  • Ran bun run check (lint, typecheck, tests) locally
  • Added a changeset (bun run changeset) if this changes behavior
  • Updated docs if this changes a user-facing surface
  • I have read CONTRIBUTING.md and agree to license my contribution under the project's terms (CLA)

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

I could not sync this PR automatically. A maintainer will look into it.

The diff could not be applied on our side. This is a bridge-side issue, not a problem with your PR (which is already based on the latest public base); a maintainer will look into it.

Falling back to direct application...
Falling back to direct application...
error: cannot apply binary patch to 'public/open-knowledge/artifacts/stacked-markdown-comments-screenshot.png' without full index line
error: public/open-knowledge/artifacts/stacked-markdown-comments-screenshot.png: patch does not apply
Applied patch to 'public/open-knowledge/packages/app/src/components/DocPanel.dom.test.tsx' cleanly.
Applied patch to 'public/open-knowledge/packages/app/src/components/DocPanel.tsx' cleanly.
Falling back to direct application...
Falling back to direct application...
Applied patch to 'public/open-knowledge/packages/app/src/editor/TiptapEditor.tsx' cleanly.
Falling back to direct application...
Falling back to direct application...
Falling back to direct application...
Falling back to direct application...
Falling back to direct application...
Applied patch to 'public/open-knowledge/packages/app/src/globals.css' cleanly.
Applied patch to 'public/open-knowledge/packages/app/src/locales/en/messages.json' cleanly.
Applied patch to 'public/open-knowledge/packages/app/src/locales/en/messages.po' cleanly.
Applied patch to 'public/open-knowledge/packages/app/src/locales/pseudo/messages.json' cleanly.
Applied patch to 'public/open-knowledge/packages/app/src/locales/pseudo/messages.po' cleanly.

@miles-kt-inkeep

miles-kt-inkeep commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Hey @lmist, thanks for the contribution. We have some internal work ongoing for this feature, but we will take your work into account as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants