Fix GitHub Enterprise host handling#612
Conversation
|
Taren Marsaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
CLA was signed but for some reason status doesn't update, possibly due to tracking config of the computer I'm using (and unable to adjust atm). |
|
Thanks for the contribution! A maintainer will review and merge your PR. Your commit attribution is preserved as @blokboy. What happens next:
This comment will be updated as the status changes. |
Hi @blokboy, could you add the email address used for this commit to your account? |
|
Should be amended now. |
What & why
Addressing Issue #597
How this was verified
bun run checkfollowed by spinning up the Electron shell locally.Checklist
bun run check(lint, typecheck, tests) locally(Note: The full gate is blocked by an upstream desktop test issue on
origin/main:packages/desktop/tests/unit/verify-native-config-driver.test.mjsimports missingscripts/verify-native-config-in-packaged-dmg.mjs. I also hit sandbox/Cargo env issues first, then worked around those with--env-mode=loose)bun run changeset) if this changes behaviorAfter you open this PR
See CONTRIBUTING.md for details.