Skip to content

[GP-33873] Make php 8.4 changes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ischwy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GP-33873] Make php 8.4 changes #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Forked version to add namespacing

### 5.0.3
* Make some php 8.4 related changes
Copy link
Member

@Crease29 Crease29 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is a breaking change and should be reflected by bumping the minor version number, instead of the patch version number.

* update docker files
* update composer packages
* added rector for future upgrades & changes

### 5.0.2
* Added support for PHP 8.2 (and above)

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM redis:7.0.7-bullseye
FROM redis:latest

ARG DEBIAN_FRONTEND=noninteractive

Expand All @@ -13,7 +13,7 @@ RUN curl -fsSL https://packages.sury.org/php/apt.gpg| gpg --dearmor -o /etc/apt

# Install php
RUN apt update
RUN apt install php8.1 php8.1-dom php8.1-mbstring php8.1-curl -y
RUN apt install php8.4 php8.4-dom php8.4-mbstring php8.4-curl -y

# Install tools
RUN apt install zip unzip php-zip -y
Expand Down
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Copy link
Member

@Crease29 Crease29 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect the PHP version requirement to be increased. Some of the changes, like typed constants, aren't available in the currently required PHP version.

Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@
"require-dev": {
"colinmollenhour/credis": "^1.11",
"predis/predis": ">=1.1",
"phpunit/phpunit": "^9.4",
"monolog/monolog": "^2.0"
"phpunit/phpunit": "^9",
"monolog/monolog": "^2.0",
"rector/rector": "^2.2"
},
"extra": {
"branch-alias": {
Expand Down
Loading