Skip to content

Fix access to None members for ServertypeAttributeAdminForm #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kofrezo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix access to None members for ServertypeAttributeAdminForm #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions serveradmin/serverdb/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ class Meta:

def clean(self):
# It makes no sense to add inet or supernet attributes to hosts of
# ip_addr_type null because they would have to be empty anyways.
# ip_addr_type null because they would have to be empty anyway.
inet_attribute = (
'attribute' in self.cleaned_data and
self.cleaned_data['attribute'].type in ('inet', 'supernet') and
self.instance.servertype.ip_addr_type == 'null'
self.cleaned_data['servertype'].ip_addr_type == 'null'
)
if inet_attribute:
raise ValidationError(
Expand Down
Loading