build(many): remove commonjs build - #2683
Draft
joyenjoyer wants to merge 2 commits into
Draft
joyenjoyer wants to merge 2 commits into
joyenjoyer wants to merge 2 commits into
Conversation
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (1)badge-canvas.png — 1573 pixels differBaselines come from the |
balzss
removed their request for review
September 1, 2026 08:44
joyenjoyer
marked this pull request as draft
September 7, 2026 14:27
joyenjoyer
force-pushed
the
chore-remove-dead-babel-plugins
branch
2 times, most recently
from
September 24, 2026 14:31
0b9bd46 to
b02a710
Compare
Remove the --modules flag and the cjs branch from `ui-scripts build`, along
with specify-commonjs-format.ts (which stamped lib/package.json with
{"type":"commonjs"}). Only the es build remains.
Switch generate-all-tokens to dynamic import() of the es output instead of
require()-ing the lib output.
Ship every InstUI package ESM-only: drop the `lib`/CommonJS build output, `main` field, and `require` export conditions in favor of `type: module` and the existing `es` output. Rename each package's babel.config.js to babel.config.cjs (needed once the package itself is type: module).
joyenjoyer
force-pushed
the
INSTUI-5148-remove-common-js-v2
branch
from
September 25, 2026 15:26
4f4d529 to
20b5b9b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--modules cjsbuild path fromui-scripts build(babel.ts,specify-commonjs-format.ts) and switchgenerate-all-tokensto import fromes/instead ofrequire()-inglib/@instructure/*package ESM-only: remove thelib/CommonJS output,mainfield, andrequireexport conditions; addtype: module; rename each package'sbabel.config.jstobabel.config.cjsStacked on #2682 (dead babel plugin removal) — base branch will move to
masteronce that merges.Test Plan
pnpm run bootstrap,tsc -b, oxlint, and vitest.Fixes INSTUI-5148
🤖 Generated with Claude Code