chore: freeze themes - #2725
Merged
Merged
chore: freeze themes#2725
Conversation
HerrTopi
force-pushed
the
test-freeze
branch
from
September 22, 2026 08:52
a2825e6 to
3cf48ba
Compare
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (28)alert-canvas.png — 753 pixels differalert-dark.png — 2385 pixels differalert-light.png — 2442 pixels differavatar-dark.png — 107 pixels differavatar-light.png — 107 pixels differbadge-canvas.png — 1573 pixels differbillboard-dark.png — 36899 pixels differbillboard-light.png — 36841 pixels differcolorpicker-dark.png — 50708 pixels differcolorpicker-light.png — 39157 pixels differcustom-icons-canvas.png — 565 pixels differcustom-icons-dark.png — 498 pixels differcustom-icons-light.png — 594 pixels differfiledrop-dark.png — 6892 pixels differfiledrop-light.png — 6957 pixels differheading-dark.png — 27544 pixels differheading-light.png — 27459 pixels differprogressbar-canvas.png — 1661 pixels differprogressbar-dark.png — 1672 pixels differprogressbar-light.png — 1661 pixels differsmall-components-canvas.png — 85 pixels differsmall-components-dark.png — 319 pixels differsmall-components-light.png — 408 pixels differtooltip-dark.png — 84597 pixels differtooltip-light.png — 82455 pixels differview-canvas.png — 1088 pixels differview-dark.png — 2112 pixels differview-light.png — 2112 pixels differBaselines come from the |
HerrTopi
force-pushed
the
test-freeze
branch
2 times, most recently
from
September 22, 2026 09:06
757c81c to
97552aa
Compare
HerrTopi
force-pushed
the
test-freeze
branch
from
September 22, 2026 09:39
97552aa to
0c747c2
Compare
HerrTopi
force-pushed
the
test-freeze
branch
from
September 22, 2026 10:19
0c747c2 to
05078cf
Compare
matyasf
requested changes
Sep 22, 2026
matyasf
left a comment
Collaborator
There was a problem hiding this comment.
- in
withStyleNewline 165 is a crash iffrozenTheme[themeKey]does not exist the code will crash a bit later when trying to accesstheme.newTheme.primitives
maybe throw an error instead of console.error in line 156? - A Select test is failing, I guess because of the new theme tokens? perhaps generalize that test?
otherwise it looks good!
HerrTopi
force-pushed
the
test-freeze
branch
from
September 22, 2026 15:09
05078cf to
d70728f
Compare
matyasf
approved these changes
Sep 23, 2026
joyenjoyer
requested changes
Sep 29, 2026
Alert v2 and Pill v2 now resolve their component tokens from a frozen snapshot of design tokens v1 instead of the live theme, so their styling stays put while the shared token set keeps moving. Both pass frozenThemesDesignTokensV1 to withStyleNew and type themeOverride against DesignTokensV1ComponentTypes. For a frozen component, themeOverride.components now accepts either the frozen token shape or the current one, but rejects a mix of the two. Keys from the wrong shape used to typecheck and then get silently ignored at runtime. Bumps @instructure/instructure-design-tokens from v1.5.0 to v1.9.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
joyenjoyer
self-requested a review
October 1, 2026 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.























chore(many): freeze Alert and Pill v2 against design tokens v1
Alert v2 and Pill v2 now resolve their component tokens from a frozen snapshot of design
tokens v1 instead of the live theme, so their styling stays put while the shared token set
keeps moving. Both pass frozenThemesDesignTokensV1 to withStyleNew and type themeOverride
against DesignTokensV1ComponentTypes.
For a frozen component, themeOverride.components now accepts either the frozen token shape
or the current one, but rejects a mix of the two. Keys from the wrong shape used to
typecheck and then get silently ignored at runtime.
Bumps @instructure/instructure-design-tokens from v1.5.0 to v1.9.0.