Merged
Conversation
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff: ✅ No changes.
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Baselines come from the |
…nd DataPermissionLevels AiInformation v2 hardcoded the Popover screenReaderLabel to "Popover Dialog Example", which was both untranslatable and meaningless to screen reader users. It now uses the title prop. The privacy notice Link also accepts an optional privacyNoticeScreenReaderLabel so consumers can announce that it opens an external page. DataPermissionLevels v2 rendered each card's content container as a plain div, leaving the list of permission levels without heading semantics. It is now an h3 with the default heading styles reset. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
matyasf
reviewed
Sep 29, 2026
| isShowingContent={open} | ||
| on="click" | ||
| screenReaderLabel="Popover Dialog Example" | ||
| screenReaderLabel={`IgniteAI, ${title}`} |
Collaborator
There was a problem hiding this comment.
This is not so nice, we still have some hardcoded text...
matyasf
approved these changes
Sep 29, 2026
git-nandor
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AiInformationv2: replace the hardcodedscreenReaderLabel="Popover Dialog Example"on the Popover with thetitleprop.AiInformationv2: add an optionalprivacyNoticeScreenReaderLabelto eachdataentry, applied as the privacy notice Link'saria-labelso consumers can announce that it opens an external page.DataPermissionLevelsv2: render each card's content container as anh3instead of adivso the permission levels carry heading semantics, withall: unsetstripping the default heading styles.Test Plan
AiInformationpopover and confirm it announces thetitletext rather than "Popover Dialog Example".privacyNoticeScreenReaderLabelwhen supplied, and still falls back to its visible text when omitted.DataPermissionLevelsby headings and confirm each permission level card is reachable at level 3.DataPermissionLevelscards against master — thedivtoh3swap plusall: unsetshould be a no-op, so check the content container's spacing, font size, and weight are unchanged.Fixes INSTUI-5197
🤖PR description ONLY Generated with Claude Code