feat(ui-heading): add AI Heading iconOnly sizes for every Heading variant - #2738
Open
joyenjoyer wants to merge 1 commit into
Open
joyenjoyer wants to merge 1 commit into
joyenjoyer wants to merge 1 commit into
Conversation
…iant aiVariant="iconOnly" now sizes its AI icon per variant to match the Figma spec (32, 24, 20, and 16px) instead of reusing the horizontal lockup sizes. Level and as sizing are unchanged. Existing iconOnly headings that set a variant render a slightly larger icon. Generalize the AI Heading README section and add the sizes to the regression-test page. INSTUI-5190 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (5)badge-canvas.png — 1573 pixels differheading-canvas.png — 560765 pixels differheading-dark.png — 562701 pixels differheading-light.png — 562551 pixels differtooltip-light.png — 956 pixels differBaselines come from the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiVariant="iconOnly"sizes the AI icon pervariantto match Figma (32/24/20/16px) instead of reusing the horizontal lockup sizes;level/assizing unchangediconOnly+variantheadings now render a slightly larger iconiconOnlysize row to the heading regression-test pageTest Plan
iconOnlyexample's icon size against the Figma frame (node 10463-47717)Fixes INSTUI-5190
🤖 Generated with Claude Code