Add post process method for linting error

This post process method removes other errors if
they are in the same line ad in2 errors.

This is because in2 is reported when there are tabs in the
document, which causes miss calculations in indentation
levels.

Author: alecalvop

example_files/example_lint_cfg.json

@@ -6,6 +6,7 @@
     "nsp_unary": {},
     "nsp_trailing": {},
     "long_lines": { "max_length": 80 },
+    "in2": {},
     "in3": { "indentation_spaces": 4 },
     "continuation_line": { "indentation_spaces": 4 },
     "in9": { "indentation_spaces": 4 }

src/analysis/parsing/parser.rs

@@ -369,14 +369,8 @@ impl <'a> FileParser<'a> {
                     self.advance();
                 },
                 TokenKind::Whitespace => {
-                    let slice = self.lexer.slice();
-                    for ch in slice.chars() {
-                        if ch == '\t' {
-                            self.current_column += 4;
-                        } else {
-                            self.current_column += 1;
-                        }
-                    }
+                    // TODO: this might not work correctly with tabs
+                    self.current_column += self.lexer.slice().len() as u32;
                     self.advance();
                 },
                 TokenKind::MultilineComment => {

src/lint/mod.rs

@@ -3,12 +3,13 @@ use std::fs;
 use std::path::{Path, PathBuf};
 use log::{debug, error, trace};
 use serde::{Deserialize, Serialize};
-use rules::{instantiate_rules, CurrentRules};
+use rules::indentation::IN2Rule;
+use rules::{Rule, instantiate_rules, CurrentRules};
 use rules::{spacing::{SpBraceOptions, SpPunctOptions, NspFunparOptions,
                       NspInparenOptions, NspUnaryOptions, NspTrailingOptions},
-                      indentation::{LongLineOptions, IN2Options, IN3Options,
-                                    IN9Options, ContinuationLineOptions},
-                    };
+            indentation::{LongLineOptions, IN2Options, IN3Options,
+                          IN9Options, ContinuationLineOptions},
+            };
 use crate::analysis::{DMLError, IsolatedAnalysis, LocalDMLError};
 use crate::analysis::parsing::tree::TreeElement;
 use crate::file_management::CanonPath;
@@ -137,9 +138,26 @@ pub fn begin_style_check(ast: TopAst, file: String, rules: &CurrentRules) -> Res
     // Continuation line check
     rules.continuation_line.check(&mut linting_errors, &lines);
 
+    post_process_linting_errors(&mut linting_errors);
+
     Ok(linting_errors)
 }
 
+fn post_process_linting_errors(errors: &mut Vec<LocalDMLError>) {
+    // Collect in2 ranges
+    let in2_ranges: Vec<_> = errors.iter()
+        .filter(|error| error.description == IN2Rule::description())
+        .map(|error| error.range)
+        .collect();
+
+    // Remove linting errors that are in in2 rows
+    errors.retain(|error| {
+        !in2_ranges.iter().any(|range|
+            (range.row_start == error.range.row_start || range.row_end == error.range.row_end)
+            && error.description != IN2Rule::description())
+    });
+}
+
 #[derive(Copy, Clone)]
 pub struct AuxParams {
     pub depth: u32,

src/lint/rules/tests/indentation/in2.rs

@@ -0,0 +1,62 @@
+use crate::lint::rules::tests::common::set_up;
+use crate::lint::rules::tests::indentation::assert_indentation;
+
+pub static IN2_USING_TAB_INDENT: &str = "
+bank BankA {
+    group GroupB {
+        param some_param = this.REG_C;
+        register REG_C[osdml_reg_idx < ...] is (some_template) {
+            param other_param = 0;
+            field Field_D {
+            	is osdml_write;
+    		    method write_action(uint64 value) {
+                    if (value == 1) {
+                        log info, 3: \"Writing Field_D\";
+                    }
+                }
+    	    }
+            method is_even(int value) -> (uint32) {
+                if (value % 2 == 0) {
+                    return true;
+	    	    } else
+                    return false;
+            }
+        }
+    }
+}
+";
+#[test]
+fn in2_using_tab_indent() {
+    let rules = set_up();
+    assert_indentation(IN2_USING_TAB_INDENT, 6, rules);
+}
+
+pub static IN2_USING_SPACE_INDENT: &str = "
+bank BankA {
+    group GroupB {
+        param some_param = this.REG_C;
+        register REG_C[osdml_reg_idx < ...] is (some_template) {
+            param other_param = 0;
+            field Field_D {
+                is osdml_write;
+                method write_action(uint64 value) {
+                    if (value == 1) {
+                        log info, 3: \"Writing Field_D\";
+                    }
+                }
+            }
+            method is_even(int value) -> (uint32) {
+                if (value % 2 == 0) {
+                    return true;
+                } else
+                    return false;
+            }
+        }
+    }
+}
+";
+#[test]
+fn in2_using_space_indent() {
+    let rules = set_up();
+    assert_indentation(IN2_USING_SPACE_INDENT, 0, rules);
+}