Implement line length and breaking rules #109
Conversation
jvsqzj
changed the title
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
from
a36462e to
d9bb070
Compare
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
from
d9bb070 to
3110e82
Compare
me-cr
force-pushed
the
feature/73-line-breaking
branch
7 times, most recently
from
b934564 to
cca1d93
Compare
me-cr
force-pushed
the
feature/73-line-breaking
branch
2 times, most recently
from
ed9dae7 to
faf5b2a
Compare
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
3 times, most recently
from
308ee69 to
18a10ea
Compare
* Add MethodOutputBreak (LL5) Rule
* Add LL3 rule for conditional expression breaking * Cover more test cases * Add ll3 to features.md * Add to example_lint_cfg
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
from
18a10ea to
d9825d1
Compare
JonatanWaern
left a comment
JonatanWaern
left a comment
There was a problem hiding this comment.
Will examine further next week, but looks good so far
JonatanWaern
left a comment
JonatanWaern
left a comment
There was a problem hiding this comment.
I think the changelog merge conflict blocks the ability to run a CI on this (which is weird), but likely you need to run clippy on this also
|
@jvsqzj I am not familiar with the restrictions on commits on GH PRs, do you need me to merge in the suggested changes or are these more for me to preview what is happening? |
dtarassenko
force-pushed
the
feature/73-line-breaking
branch
from
eae072a to
8745d24
Compare
dtarassenko
force-pushed
the
feature/73-line-breaking
branch
from
8745d24 to
a5cb86b
Compare
…dml-language-server into feature/73-line-breaking
We do need you to merge, as none of us has write permissions to upstream. |
|
LGTM at this point, nice work! final ACK. from you (@jvsqzj ) and then Ill push the big green button. |
|
Thanks! Lets get it merged |
5 participants
This PR introduces Line Length and Breaking style rules to the lint module. It also covers rule IN6 which was left out of scope for previous Indentation rules patch and had important implications for line length implementation.