qat: handle service parsing via debugfs #2167
Conversation
The QAT out-of-tree driver does not provide sysfs based cfg_services interface to read (and write) services configurations so QAT debugfs is used as the fallback. bad65eb changed how the services string is parsed and trimmed but missed the debugfs path. Because of this, the resource registration errors due so invalid resource names (e.g., "sym;dc", which should be "sym-dc"). Fix by handling the debugfs path the same way as the cfg_services sysfs path. Signed-off-by: Mikko Ylinen <[email protected]>
| } | ||
|
|
||
| return devCfg.Section("GENERAL").Key("ServicesEnabled").String() | ||
| return strings.Join(strings.SplitN(strings.TrimSpace(devCfg.Section("GENERAL").Key("ServicesEnabled").String()), ";", 3), "-") |
There was a problem hiding this comment.
The line is complicated enough that I think a helper function should be used both here, and on same operation done for on earlier line in this function => helper function could be internal to this function.
There was a problem hiding this comment.
I was slightly disappointed Go formatter could not do anything about it.
There was a problem hiding this comment.
I would agree with @eero-t . A helper function would be nice. Maybe even with a comment what it tries to do.
|
SGX test fails due to SHA checksum failure, and I guess that's why rest of the rests are cancelled? |
yup. I'll fix/update this image separately later this week |
|
Hi @mythi |
4 participants
Fixes: #2168
The QAT out-of-tree driver does not provide sysfs based cfg_services interface to read (and write) services configurations so QAT debugfs is used as the fallback.
bad65eb changed how the services string is parsed and trimmed but missed the debugfs path. Because of this, the resource registration errors due to invalid resource names (e.g., "sym;dc", which should be "sym-dc").
Fix by handling the debugfs path the same way as the cfg_services sysfs path.