Misc GPU updates #2172
Misc GPU updates #2172
Conversation
Signed-off-by: Tuomas Katila <[email protected]>
| apt-get update && apt-get install --no-install-recommends -y ocl-icd-libopencl1 && \N | ||
| rm /runtime/level-zero-devel_*.deb && \N | ||
| cd /runtime && dpkg -i *.deb && rm -rf /runtime && \N | ||
| apt-get update && apt-get install --no-install-recommends -y ocl-icd-libopencl1 wget ca-certificates && \N |
There was a problem hiding this comment.
I suspect the main size reduction from this duplication comes actually from removing the accidentally left (large) downloaded deb files, not from dropping l0-dev, wget, certs & their deps. Did you check that?
There was a problem hiding this comment.
It mainly comes from this:
COPY --from=builder /runtime /runtime
The runtime deb packages are copied from the build to the final phase, and while they are removed after the install the copy creates a large unnecessary layer. This is evident if you open the container in dive.
Would be nice if one could install packages directly from the build phase.
There was a problem hiding this comment.
docker does not support host volumes for builds (needs extension), but podman does. What if packages were on a host tmp volume (-v $(mktemp -d):/temporary:rw), I don't think those go to the final image?
Use the existing "temp-limit" as the global limit, and introduce GPU and memory thresholds. Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
gpu-misc-updates
branch
from
7835046 to
426558c
Compare
Fix uninitialized variable that caused random behaviour. Signed-off-by: Tuomas Katila <[email protected]>
By re-downloading the components, we save on the overall container size. While the build time increases slightly, the container size drops by around 100M (520->420). Signed-off-by: Tuomas Katila <[email protected]>
tkatila
force-pushed
the
gpu-misc-updates
branch
from
426558c to
f270956
Compare
eero-t
left a comment
eero-t
left a comment
There was a problem hiding this comment.
Approved. Additional container improvements don't need to be part of this PR.
2 participants
Fixes #2166