Skip to content

Conversation

@ericcraw
Copy link

This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.

@sfatimar
Copy link

Which APIs are we trying to import the allocator too. Can you give some more context on the use case.

@ericcraw
Copy link
Author

This is a a windows use case. Specifically "importing" allocation to DX12 to share with the GPU by creating a system memory DX12 heap from the GPU using the CPU VA returned from the allocator. D3D runtime seems to require that the CPU VA point to the base address of the allocation to create the heap.

Given that the allocator's lifetime is required to extend beyond it's allocations, the allocator is free to save internal state so this implementation shouldn't be a problem. In fact it'll likely save a small amount memory on a whole (since it doesn't save an extra page for each allocation for alignment + metadata).

Copy link

@sfatimar sfatimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@sfatimar
Copy link

Please update branch

This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
@ericcraw ericcraw force-pushed the same_base_addr_alloc branch from af27ecf to f5543b2 Compare March 13, 2025 18:47
@jnagi-intel
Copy link

@sfatimar Can you please get this change upstreamed to msft main ? This is required for Auto SR enabling.

@sfatimar sfatimar merged commit 7683e37 into intel:ovep-develop Mar 17, 2025
1 check passed
ankitm3k pushed a commit that referenced this pull request Apr 1, 2025
This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
ankitm3k pushed a commit that referenced this pull request Apr 1, 2025
This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
ankitm3k pushed a commit that referenced this pull request Apr 2, 2025
This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
ankitm3k pushed a commit that referenced this pull request Apr 4, 2025
This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
ankitm3k pushed a commit that referenced this pull request Apr 9, 2025
This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
ankitm3k pushed a commit that referenced this pull request Jul 2, 2025
This change allows for allocations made by the ov allocator to be
imported to other APIs that require base addresses to the original
device allocation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants