[CVS-169168] Change name of metadata file and add filepath validation #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayureshV1
reviewed
Jun 20, 2025
MayureshV1
reviewed
Jun 23, 2025
javier-intel
force-pushed
the
jemartin/weight_sharing_metadata_fix
branch
from
1f09229 to
9b3e51d
Compare
…r.cc Add Metadata file path to error string Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
javier-intel
force-pushed
the
jemartin/weight_sharing_metadata_fix
branch
from
9b3e51d to
21506c6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the EPctx metadata behavior by renaming the metadata file and adding filepath validation to enhance the weight sharing scenario.
- Adjusted metadata file paths during both inference and generation phases.
- Refactored error handling messages when reading and writing metadata.
- Added a new member in the shared context to store metadata file path.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| onnxruntime/core/providers/openvino/openvino_execution_provider.cc | Updated metadata reading and generation logic with filepath validation and improved error handling. |
| onnxruntime/core/providers/openvino/contexts.h | Added a new field to store the metadata file path. |
| onnxruntime/core/providers/openvino/backend_manager.cc | Adjusted metadata-dependent operations and error reporting for initializer file. |
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
…r.cc Co-authored-by: Copilot <[email protected]>
javier-intel
force-pushed
the
jemartin/weight_sharing_metadata_fix
branch
from
da39e24 to
73de0f1
Compare
MayureshV1
approved these changes
Jun 25, 2025
ankitm3k
pushed a commit
that referenced
this pull request
Jul 2, 2025
…#717) * Change name of metadata file and add filepath validation * Save metadata file path in shared context for use across model compilation * Fix metadata file path initialization * Check that metadata file is created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix EPctx Metadata behavior for weight sharing scenario and update naming convention to avoid weights duplication
Motivation and Context
Fixes a Phi Silica accuracy failure when external data file is in original folder but EPCtx, metadata and blobs are in a separate folder
https://jira.devtools.intel.com/browse/CVS-169168