Fix node backend crash on fresh clone: migrate in start script + Express 5 - #88
Merged
Merged
Conversation
script/node/start never ran db:migrate, so on a fresh clone the server booted against an empty SQLite file and the first query crashed the process with an unhandled rejection (Express 4 does not forward async handler rejections to the error handler). - Add pnpm db:migrate to script/node/start and start.bat - Upgrade express 4 -> 5 so async handler errors return 500 instead of killing the process (@types/express was already on v5) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
SeanHealy33
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
script/node/startnever randb:migrate, so on a fresh clone the server booted against an empty SQLite file and the first database query crashed the whole process. Express 4 does not forward rejected promises from async route handlers to the error middleware, so any Sequelize error became an unhandled rejection and killed the server.How?
Run migrations in the start scripts (bash and Windows), and upgrade Express 4 → 5, which forwards async handler rejections to the error handler so a DB error returns a 500 instead of exiting the process (
@types/expresswas already on v5).Generated with Claude Code