Skip to content

Exception shoudn't be raised when no message catalogs #378

Description

@fenekku

Package version (if known): v1.5.0

Describe the bug

When running invenio-cli services setup, for an instance that doesn't use translations, the following exception is thrown and shows up on the terminal:

# ...
Created required fixtures! 
Compiling message catalog...                                                                                                                                                 
Loading .env environment variables...                                                                                                                                        
Traceback (most recent call last):                                                                                                                                           
  File "/home/me/my-project/.venv/bin/pybabel", line 8, in <module>                                                                                       
    sys.exit(main())                                                                                                                                                         
  File "/home/me/my-project/.venv/lib/python3.9/site-packages/babel/messages/frontend.py", line 999, in main                                              
    return CommandLineInterface().run(sys.argv)                                                                                                                              
  File "/home/me/my-project/.venv/lib/python3.9/site-packages/babel/messages/frontend.py", line 925, in run                                               
    return cmdinst.run()                                                                                                                                                     
  File "/home/me/my-project/.venv/lib/python3.9/site-packages/babel/messages/frontend.py", line 199, in run                                               
    for errors in self._run_domain(domain).values():                                                                                                                         
  File "/home/me/my-project/.venv/lib/python3.9/site-packages/babel/messages/frontend.py", line 237, in _run_domain                                       
    raise OptionError('no message catalogs found')                                                                                                                           
babel.messages.frontend.OptionError: no message catalogs found  

Declaring queues...
# ...

This doesn't prevent the rest of the steps to go ahead, but is alarming to the lay-developer. Absence of translations should not be a concern.

Expected behavior

Multiple avenues are possible. Either:

  • like custom fields, print out No message catalogs found. Exiting... in green
  • like custom fields but in orange and using "skipping": "No message catalogs found. Skipping."
  • not even attempting to compile message catalogs in the first place
  • not printing anything following "Compiling message catalog..."

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions