Replaced *args with args#112
Closed
invisibleroads wants to merge 7 commits intoinvisibleroads:0.5.7from
Closed
Conversation
*args caused dictionary packets to get stripped of values and as a result, keys were only left, which is useless.
…server implementations.
Owner
Author
|
I double-checked and the 0.6 series does not have this issue. This might have been an issue with the 0.5 series, but I haven't had the heart to check it and none of the tests in this pull request are passing. |
Owner
Author
|
As much as I would like to approve this pull request, I am not able to merge it at the moment. If I find more time, I will take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving @jyapayne's pull request #104