Skip to content

[Repo Assist] Add --msbuild-global-property CLI option for design-time project loading #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Repo Assist] Add --msbuild-global-property CLI option for design-time project loading #1524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932e2ea
Add --msbuild-global-property CLI option for design-time project loading
github-actions[bot] Apr 8, 2026
78942c6
ci: trigger checks
github-actions[bot] Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/FsAutoComplete/Parser.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ module Parser =

o

let msBuildGlobalPropertyOption =
let o = Option<string[]>("--msbuild-global-property", "--msbuild-prop")

o.Description <-
"Add or override an MSBuild global property for design-time project loading. Specify as KEY=VALUE, e.g. --msbuild-global-property Configuration=Release. Can be specified multiple times."

o.AllowMultipleArgumentsPerToken <- true
o

let stateLocationOption =
let o = Option<DirectoryInfo>("--state-directory")

Expand All @@ -111,6 +120,7 @@ module Parser =
rootCommand.Options.Add stateLocationOption
rootCommand.Options.Add otelTracingOption
rootCommand.Options.Add useTransparentCompilerOption
rootCommand.Options.Add msBuildGlobalPropertyOption

// for back-compat - we removed some options and this broke some clients.
rootCommand.TreatUnmatchedTokensAsErrors <- false
Expand All @@ -120,12 +130,24 @@ module Parser =
let adaptiveLspEnabled = parseResult.GetValue(adaptiveLspServerOption)
let useTransparentCompiler = parseResult.GetValue(useTransparentCompilerOption)

let extraMsBuildProperties =
parseResult.GetValue(msBuildGlobalPropertyOption)
|> Option.ofObj
|> Option.defaultValue [||]
|> Array.choose (fun (kv: string) ->
match kv.IndexOf('=') with
| -1 -> None
| i -> Some(kv.[.. i - 1], kv.[i + 1 ..]))
|> Array.toList

let workspaceLoaderFactory =
fun toolsPath ->
let properties = ProjectLoader.globalProperties @ extraMsBuildProperties

if projectGraphEnabled then
Ionide.ProjInfo.WorkspaceLoaderViaProjectGraph.Create(toolsPath, ProjectLoader.globalProperties)
Ionide.ProjInfo.WorkspaceLoaderViaProjectGraph.Create(toolsPath, properties)
else
Ionide.ProjInfo.WorkspaceLoader.Create(toolsPath, ProjectLoader.globalProperties)
Ionide.ProjInfo.WorkspaceLoader.Create(toolsPath, properties)

let sourceTextFactory: ISourceTextFactory = new RoslynSourceTextFactory()

Expand Down
Loading