Repository navigation
Conversation
Full nodes no longer serve JSON-RPC subscriptions over WebSocket; subscribeEvent and subscribeTransaction were already deprecated there and the indexer never served them. - Remove the JSON-RPC WebSocket client. IotaHTTPTransport.subscribe fails with an error that points to IotaClientGraphQLTransport, and its WebSocketConstructor and websocket options are deprecated and ignored. - IotaClientGraphQLTransport no longer falls back to JSON-RPC for subscriptions; a filter GraphQL cannot express is refused. - Document the supported subscription filters in the graphql-transport README.
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
iotax_subscribeEventandiotax_subscribeTransactionwere already deprecated in favour ofqueryEventsandqueryTransactionBlocks, and the indexer never served them.IotaClient.subscribeEventandsubscribeTransactionkeep working throughIotaClientGraphQLTransport, which serves them with GraphQL subscriptions.@iota/iota-sdk: removes the JSON-RPC WebSocket client.IotaHTTPTransport.subscribenow fails with an error that points to the GraphQL transport. TheWebSocketConstructorandwebsocketoptions are kept as deprecated and ignored, so existing code still compiles.@iota/graphql-transport: subscriptions no longer fall back to JSON-RPC; a filter that GraphQL cannot express is refused. The README lists the supported subscription filters, and no longer listssubscribeEvent/subscribeTransactionas unsupported.Links to any relevant issues
None.
How the change has been tested
oxfmt. Not type-checked or run locally (dependencies not installed); relies on CI.wsand@types/wsstay in@iota/iota-sdk's devDependencies although nothing uses them any more, to avoid touchingpnpm-lock.yamlwithout pnpm.