Skip to content

Conversation

@ipetkov
Copy link
Owner

@ipetkov ipetkov commented Jun 19, 2023

Motivation

This is a much simpler (i.e. less ambitious, and easier to land) version of #322

Dependency *.rlib and *.rmeta files never change (as they would only change if Cargo.lock changes which would invalidate the entire build anyway) so we can get away with symlinking them to the inherited artifacts instead of having to deeply copy the files.

Fewer copies means faster builds!

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

@ipetkov ipetkov enabled auto-merge (squash) June 19, 2023 20:26
@ipetkov ipetkov disabled auto-merge June 19, 2023 21:45
@ipetkov ipetkov enabled auto-merge (squash) June 19, 2023 21:45
@ipetkov ipetkov merged commit bd65e0e into master Jun 19, 2023
@ipetkov ipetkov deleted the symlink-artifacts branch June 19, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants