fix: add null pointer checks in route_new_entry to prevent crashes #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid crashes when new_route->mtu = port->mtu; Signed-off-by: xuweiwei_yewu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds null pointer validation for the port parameter in the route_new_entry function to prevent potential crashes when accessing port->mtu. The change enhances defensive programming by ensuring both dest and port parameters are validated before proceeding with route entry creation.
- Added null check for
portparameter alongside existingdestvalidation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ytwang0320
added
the
pr/codes-reviewed-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid crashes when
new_route->mtu = port->mtu;