Conversation
Remove the local copy of the NormalForm dialect and rely on the upstream MLIR interfaces from the transform dialect instead. Additional functionally is introduced to walk attributes and types since upstream doesn't currently provide native support for that. It keeps checking the form despite seeing silenceable failures with the idea that these may be silenced later and we don't want to miss a definite failure later in the IR, similarly to the upstream design. This functionality may later be moved upstream as well. Remove the test scaffolding that was needed to verify the NormalForm dialect. Requires LLVM bump, available as commit 9deb1c631b11230787f0fb56583b17f060b194a0 in https://github.com/ftynse/llvm-project Signed-off-by: Alex Zinenko <git@ozinenko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the local copy of the NormalForm dialect and rely on the upstream MLIR interfaces from the transform dialect instead. Additional functionally is introduced to walk attributes and types since upstream doesn't currently provide native support for that. It keeps checking the form despite seeing silenceable failures with the idea that these may be silenced later and we don't want to miss a definite failure later in the IR, similarly to the upstream design. This functionality may later be moved upstream as well.
Remove the test scaffolding that was needed to verify the NormalForm dialect.
Requires LLVM bump, available as commit
9deb1c631b11230787f0fb56583b17f060b194a0 in
https://github.com/ftynse/llvm-project